Don't optimize alloc_stack with dynamic_lifetime in TempLValueElimination#88594
Open
meg-gupta wants to merge 1 commit intoswiftlang:mainfrom
Open
Don't optimize alloc_stack with dynamic_lifetime in TempLValueElimination#88594meg-gupta wants to merge 1 commit intoswiftlang:mainfrom
meg-gupta wants to merge 1 commit intoswiftlang:mainfrom
Conversation
…tion The [dynamic_lifetime] attribute represents that the stack location's initialization state is tracked dynamically via a boolean flag — it may be uninitialized at certain program points. TempLValueElimination pass can replace an alloc_stack [dynamic_lifetime] with a destination alloc_stack that does not have dynamic_lifetime. This results in invalid SIL which triggers verifier errors due to lifetime mismatches in some program paths in ossa. This PR fixes this issue by bailing out of TempLValueElimination for alloc_stack [dynamic_lifetime] in ossa. Resolves rdar://175097584
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue by bailing out of TempLValueElimination for alloc_stack [dynamic_lifetime] in ossa.
Scope: Affects
alloc_stackwithdynamic_lifetimeIssues: rdar://175097584 and Mem2Reg pass crashes with OSSACompleteLifetime error on function with optional String parameters #88545
Risk: Low. Adding a bailout for illegal optimization
Testing: Added unit test, CI testing