[cxx-interop] Do not import default arguments of constructors that require template instantiation#88589
Draft
egorzhdan wants to merge 1 commit intoswiftlang:mainfrom
Draft
[cxx-interop] Do not import default arguments of constructors that require template instantiation#88589egorzhdan wants to merge 1 commit intoswiftlang:mainfrom
egorzhdan wants to merge 1 commit intoswiftlang:mainfrom
Conversation
…quire template instantiation After a2b7b8f, Swift began emitting template instantiation errors for the default expression of `std::set` constructor that takes a comparator. The default expression calls the default constructor of the comparator type, which might be deleted. This change backs out default arguments of constructors that require instantiation out of the feature. rdar://175267666
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a2b7b8f, Swift began emitting template instantiation errors for the default expression of
std::setconstructor that takes a comparator. The default expression calls the default constructor of the comparator type, which might be deleted.This change backs out default arguments of constructors that require instantiation out of the feature.
rdar://175267666