Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-hands-spend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: remote forms with default values defined by `field.as('text', defaultValue)` now correctly reset to the provided default values once submitted
3 changes: 3 additions & 0 deletions packages/kit/src/exports/public.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1929,6 +1929,7 @@ type InputElementProps<T extends keyof InputTypeMap> = T extends 'checkbox' | 'r
'aria-invalid': boolean | 'false' | 'true' | undefined;
get checked(): boolean;
set checked(value: boolean);
readonly defaultChecked?: boolean;
}
: T extends 'file'
? {
Expand Down Expand Up @@ -1959,13 +1960,15 @@ type InputElementProps<T extends keyof InputTypeMap> = T extends 'checkbox' | 'r
'aria-invalid': boolean | 'false' | 'true' | undefined;
get value(): string | number;
set value(v: string | number);
readonly defaultValue?: string | number;
}
: {
name: string;
type: T;
'aria-invalid': boolean | 'false' | 'true' | undefined;
get value(): string | number;
set value(v: string | number);
readonly defaultValue?: string | number;
};

type RemoteFormFieldMethods<T> = {
Expand Down
14 changes: 13 additions & 1 deletion packages/kit/src/runtime/form-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ export function create_field_proxy(target, get_input, set_input, get_issues, pat
if (prop === 'as') {
/**
* @param {string} type
* @param {string} [input_value]
* @param {unknown} [input_value]
*/
const as_func = (type, input_value) => {
const is_array =
Expand Down Expand Up @@ -736,6 +736,12 @@ export function create_field_proxy(target, get_input, set_input, get_issues, pat

if (type === 'checkbox' && !is_array) {
return Object.defineProperties(base_props, {
defaultChecked: {
enumerable: true,
get() {
return input_value;
}
},
checked: {
enumerable: true,
get() {
Expand Down Expand Up @@ -806,6 +812,12 @@ export function create_field_proxy(target, get_input, set_input, get_issues, pat

// Handle all other input types (text, number, etc.)
return Object.defineProperties(base_props, {
defaultValue: {
enumerable: true,
get() {
return input_value;
}
},
value: {
enumerable: true,
get() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,7 @@

<div class="forms">
{#each values as value (value.id)}
<form
class="form"
{...as_value_form.for(value.id).enhance(({ submit }) => {
// TODO: needed to keep the values when JS is enabled, remove when reset is implemented
submit();
})}
>
<form class="form" {...as_value_form.for(value.id)}>
<input {...as_value_form.fields.text_field.as('text', value.text_field)} />

<input {...as_value_form.fields.number_field.as('number', value.number_field)} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export const as_value_form = form(ValueSchema, async (data) => {
element.color_field = data.color_field;
element.range_field = data.range_field;
element.checkbox_field = data.checkbox_field;
await get_values().refresh();
}
});

Expand Down
3 changes: 3 additions & 0 deletions packages/kit/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1903,6 +1903,7 @@ declare module '@sveltejs/kit' {
'aria-invalid': boolean | 'false' | 'true' | undefined;
get checked(): boolean;
set checked(value: boolean);
readonly defaultChecked?: boolean;
}
: T extends 'file'
? {
Expand Down Expand Up @@ -1933,13 +1934,15 @@ declare module '@sveltejs/kit' {
'aria-invalid': boolean | 'false' | 'true' | undefined;
get value(): string | number;
set value(v: string | number);
readonly defaultValue?: string | number;
}
: {
name: string;
type: T;
'aria-invalid': boolean | 'false' | 'true' | undefined;
get value(): string | number;
set value(v: string | number);
readonly defaultValue?: string | number;
};

type RemoteFormFieldMethods<T> = {
Expand Down
Loading