fix: prefer the default error page when failing to decode the URL pathname#15744
fix: prefer the default error page when failing to decode the URL pathname#15744
Conversation
🦋 Changeset detectedLatest commit: 3bdd4ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
left a comment
There was a problem hiding this comment.
While this works, can we somehow rework this so that it returns a proper thing directly, instead of having to set the path to null and then hundreds of lines of code later return an error response?
Do you mean directly calling |
Previously, if a URL pathname could not be decoded, you'd get a text response. This PR makes it so that it renders the default error page instead which is a lot prettier for users. This only affects built apps because the Vite dev server intercepts malformed URIs
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits