Open
Conversation
Owner
Find the town Judge (FindJudge.java)Your solution is excellent and correctly solves the problem. You have accurately analyzed the time and space complexity. However, note that the overall time complexity is O(E + N) because you have two loops: one over the trust array (which has E elements) and one over the n people. So while the first loop dominates when E is large, it is still important to account for both. Your comment says O(E) which might be a minor oversight. Otherwise, your code is clean and efficient. Well done! VERDICT: PASS Ball in the Maze (TheMaze.java)Strengths:
Areas for Improvement:
Here's how you can modify the DFS to return early: private boolean dfs(int[][] maze, int i, int j, int[] destination, boolean[][] visited) {
if (i == destination[0] && j == destination[1]) {
return true;
}
if (visited[i][j]) {
return false;
}
visited[i][j] = true;
for (int[] dir : dirs) {
// ... same rolling logic
if (!visited[nr][nc]) {
if (dfs(maze, nr, nc, destination, visited)) {
return true;
}
}
}
return false;
}VERDICT: NEEDS_IMPROVEMENT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.