Using default parameters instead of conditions#21
Open
fumegalli wants to merge 1 commit intostemmlerjs:masterfrom
Open
Using default parameters instead of conditions#21fumegalli wants to merge 1 commit intostemmlerjs:masterfrom
fumegalli wants to merge 1 commit intostemmlerjs:masterfrom
Conversation
AldwinPagan
reviewed
Dec 10, 2022
AldwinPagan
left a comment
AldwinPagan
left a comment
There was a problem hiding this comment.
Seems cleaner than doing the conditions.
The only thing that worries me is the PR to master. @stemmlerjs is there any guideline to do this kind of PRs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a commit to fix every case of #20 about using default parameters instead of conditions.
In some cases Typescript correctly inferred the type. When it didn't, I added the definition.
The issue contain more detailed information.
close #20