ci: fix detect-changes fallback for workflow_dispatch#1375
Merged
steilerDev merged 1 commit intobetafrom Apr 28, 2026
Merged
Conversation
When triggered via workflow_dispatch, github.base_ref is empty, causing the git diff to fail with exit code 128. Default to main when base_ref is not set so manual dispatches work correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.4.2-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 tasks
Contributor
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect Changesstep failing with exit code 128 when triggered viaworkflow_dispatchgithub.base_refis only set forpull_requestevents; defaults tomainwhen emptyworkflow_dispatchruns to properly detect changed paths and run appropriate jobsContext
When
workflow_dispatchis used to manually trigger CI (e.g., after a[skip ci]auto-fix commit), theDetect Changesjob fails becausegithub.base_refis not set. This causes all downstream jobs to be skipped, resulting inQuality GatesandE2E Gatespassing vacuously — which blocks promotion PRs from properly establishing CI status.Test plan
Detect Changessuccessfully