WIP Add support for end seconds#521
Open
WorksDontBreak wants to merge 2 commits intostashapp:mainfrom
Open
Conversation
Author
|
I had to migrate my database to make this work locally, if im not mistaken if you run this from scratch it should just make the database correctly from the start |
Author
|
The script now supports end_seconds, and it pushes end_seconds but dosent get them when syncing, the endpoint it uses need to be updated to work with this |
Collaborator
|
cc @Tweeticoats |
DogmaDragon
added
type:plugin
DogmaDragon
requested changes
Mar 5, 2026
Contributor
DogmaDragon
left a comment
DogmaDragon
left a comment
There was a problem hiding this comment.
Needs a rebase.
Is there any need to merge this without the timestamp.trade database supporting end_seconds? As the task will never produce anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should In theory work currently testing