Fix UnboundLocalError in _get when CurlError is raised#66
Merged
lxcode merged 1 commit intostanfordio:mainfrom Apr 20, 2026
Merged
Fix UnboundLocalError in _get when CurlError is raised#66lxcode merged 1 commit intostanfordio:mainfrom
lxcode merged 1 commit intostanfordio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnboundLocalErrorinApi._get()when acurl_cffi.curl.CurlErroris raised (e.g.Send failure: Broken pipe).exceptblock logged the error but fell through to code referencingresp, which was never assigned due to the exception. Addedreturn Noneto exit early, consistent with the existing error-handling pattern for JSON decode failures.Reproduction
Fix
Return
Nonefrom theexcept CurlErrorblock so execution doesn't fall through toself._check_ratelimit(resp)andresp.json()with an unbound variable.Made with Cursor