replace stopifnot() with abort() and descriptive messages in helpers …#472
Closed
utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
Closed
replace stopifnot() with abort() and descriptive messages in helpers …#472utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
utkarshpawade wants to merge 3 commits intostan-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
This PR improves user-facing input validation in the following files:
helpers-ppc.Rhelpers-mcmc.Rmcmc-diagnostics.RReplaces all
stopifnot()checks with explicitif+rlang::abort()calls.Provides clear, descriptive error messages for invalid user input while ensuring consistent error handling across the codebase.
Why ?
stopifnot()produces opaque error messages that are difficult for users to interpret. Replacing these withabort()improves the user experience by making validation failures clearer and easier to understand.