ContributeSubComponent: Support returning Super Type#1070
Open
esafirm wants to merge 2 commits intosquare:mainfrom
Open
ContributeSubComponent: Support returning Super Type#1070esafirm wants to merge 2 commits intosquare:mainfrom
esafirm wants to merge 2 commits intosquare:mainfrom
Conversation
kevinguitar
reviewed
Nov 26, 2024
compiler/src/main/java/com/squareup/anvil/compiler/codegen/ContributesSubcomponentCodeGen.kt
Outdated
Show resolved
Hide resolved
compiler/src/main/java/com/squareup/anvil/compiler/codegen/ContributesSubcomponentCodeGen.kt
Outdated
Show resolved
Hide resolved
esafirm
force-pushed
the
contributesubcomponent-factory-return-super
branch
from
ed50ac8 to
800ce3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1044
This PR enables the
ContributesSubcomponent.Factoryto return the component super type.The capability of returning component super type is available in
@MergeComponentand is also supported in Dagger.An example of this can be super useful is when we have a base factory.
This works as expected on 2.5.0-beta09 but later throws a compile error in 2.5.0-beta10