Merged
Conversation
chillaq
reviewed
Mar 2, 2026
Contributor
chillaq
left a comment
chillaq
left a comment
There was a problem hiding this comment.
Make sure to test the async mode locally.
| """Stop receiving Split SDK events.""" | ||
| self._event_receiver = None | ||
|
|
||
| def _notify_receiver(self, split_event, event_metadata): |
Contributor
There was a problem hiding this comment.
We need an async call for this method:
async def _notify_receiver(...)
# same code
await self._event_receiver._on_split_event_async(...)
| def destroy(self, destroy_event=None): | ||
| self._factory.destroy(destroy_event) | ||
|
|
||
| async def _register_split_events_async(self): |
Contributor
There was a problem hiding this comment.
we need to use different handler for async, keep in mind async mode does not support lambda, for ex:
await em.register(...., self._notify_receiver_async())
| self._split_client_wrapper.unregister_for_split_events() | ||
| super().detach() | ||
|
|
||
| def _on_split_event(self, split_event, event_metadata): |
Contributor
There was a problem hiding this comment.
Add an async call with the same code
async def _on_split_event_async()
chillaq
approved these changes
Mar 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.