Fix creating a batch of agents across divisions with the QueryComboBox#7802
Draft
acwhite211 wants to merge 4 commits intomainfrom
Draft
Fix creating a batch of agents across divisions with the QueryComboBox#7802acwhite211 wants to merge 4 commits intomainfrom
acwhite211 wants to merge 4 commits intomainfrom
Conversation
Triggered by 42c2e10 on branch refs/heads/issue-2405-new
Triggered by b25369e on branch refs/heads/issue-2405-new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405
Fixed a few issues found when creating a batch of agents across divisions with the QueryComboBox.
Fixed cross-division Agent creation from the QueryComboBox. New resources were defaulting to the logged-in collection’s scope, which caused agents created in the popup to land in the wrong division. When
forceCollectionis set, new Agent records are explicitly scoped to that target collection’s division.Use scoped creation for both “+” and typed-create paths. Search was correctly using
forceCollection, but creation path wasn’t. Create behavior now matches search scoping.The agent already set in the new Specify user form was blank when opening the “Set User Agents” dialog box opened. I made a change to ensure that the division that the user was set to, via the collection it was assigned to, defaults to that value in the QueryComboBox.
Lastly, I went through to find where in both the front-end and back-end where a user was assumed to just have one agent. Where those instances were found, a solution of considering the user having multiple agents was addressed. In addition to this, the security of a user having permission to add/access agents in different divisions was also validated.
Checklist
self-explanatory (or properly documented)
Testing instructions