fix: remove setuptools bump to prevent pkg_resources deprecation warning#10
Draft
fix: remove setuptools bump to prevent pkg_resources deprecation warning#10
Conversation
…arning The AWS CLI build process already pins setuptools==80.9.0 in its requirements-dev-lock.txt file. Upgrading setuptools to the latest version (81+) overrides this pin and causes pkg_resources deprecation warnings in the bundled executable. The make-exe script handles all necessary dependencies including the correct setuptools version, so the explicit upgrade is unnecessary and counterproductive. Fixes the issue reported in run 01KFMPWJHPP29WVH52XVERVRX9. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Krzysztof Niepokojczycki <krzysztofn@spacelift.io>
Collaborator
|
@KNiepok - just tested this, but it doesn't solve it. the merge of this PR should auto resolve the warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS CLI build process already pins setuptools==80.9.0 in its requirements-dev-lock.txt file. Upgrading setuptools to the latest version (81+) overrides this pin and causes pkg_resources deprecation warnings in the bundled executable.
The make-exe script handles all necessary dependencies including the correct setuptools version, so the explicit upgrade is unnecessary and counterproductive.
Fixes the issue reported in run 01KFMPWJHPP29WVH52XVERVRX9.