feat: show/hide cu profiling#925
Conversation
|
@C0mberry is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR introduces a reusable
Confidence Score: 4/5Safe to merge after fixing the InspectorInstructionCard collapsible default — all other changes are clean refactors. One P1 issue: InspectorInstructionCard omits collapsible={false}, causing an unintended Collapse/Expand button to appear on the inspector page. The remaining findings are P2 style/UX concerns. The core CollapsibleCard abstraction and the CU profiling show/hide feature are well-implemented. app/components/common/InspectorInstructionCard.tsx requires a one-line fix before merge. Important Files Changed
Class Diagram%%{init: {'theme': 'neutral'}}%%
classDiagram
class CollapsibleCard {
+title: ReactNode
+children: ReactNode
+defaultExpanded: boolean
+className?: string
+headerButtons?: ReactNode
+collapsible: boolean
-expanded: boolean
+setExpanded()
}
class BaseInstructionCard {
+collapsible?: boolean
+headerButtons?: ReactNode
-showRaw: boolean
}
class InspectorInstructionCard {
+defaultRaw?: boolean
-showRaw: boolean
}
class CUProfilingCard {
+instructions: InstructionCUData[]
+unitsConsumed?: number
}
class AccountsCard_Transaction {
-showRaw: boolean
}
class TokenBalancesCardInner {
-tokenSymbols: Map
}
class AccountsCard_Inspector
class AddressTableLookupsCard
class UnknownDetailsCard {
+defaultExpanded: false
}
CollapsibleCard <|-- BaseInstructionCard : uses
CollapsibleCard <|-- InspectorInstructionCard : uses (collapsible=true by default)
CollapsibleCard <|-- CUProfilingCard : uses (new feature)
CollapsibleCard <|-- AccountsCard_Transaction : uses
CollapsibleCard <|-- TokenBalancesCardInner : uses
CollapsibleCard <|-- AccountsCard_Inspector : uses
CollapsibleCard <|-- AddressTableLookupsCard : uses
CollapsibleCard <|-- UnknownDetailsCard : uses
Reviews (2): Last reviewed commit: "resolve comments" | Re-trigger Greptile |
c46b270 to
2498392
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| | Dynamic | `/api/domain-info/[domain]` | 0 B | 0 B | | ||
| | Dynamic | `/api/geo-location` | 0 B | 0 B | | ||
| | Dynamic | `/api/metadata/proxy` | 0 B | 0 B | | ||
| | Static | `/api/metadata/proxy` | 0 B | 0 B | |
There was a problem hiding this comment.
This thing is again Static. The master should have the proper version to fix it
11b3458 to
372329f
Compare
Description
Type of change
Screenshots
Testing
Storybook
Transaction Page
Related Issues
HOO-404
Checklist
build:infoscript to update build information