feat: removed sentry logging for tokens 404 error#923
feat: removed sentry logging for tokens 404 error#923Woody4618 merged 4 commits intosolana-foundation:masterfrom
Conversation
|
@C0mberry is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR removes Confidence Score: 5/5Safe to merge — all changes are minimal, logically correct, and reduce log noise as intended. All remaining findings are P2 or below. The if/else restructuring in coingecko and jupiter routes is logically equivalent to the original; no data loss, security, or correctness issues are introduced. Rugcheck change is a one-line removal with no structural impact. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Route as Verification API Route
participant Provider as External Provider (CoinGecko/Jupiter/Rugcheck)
Client->>Route: GET /api/verification/{provider}/{id}
Route->>Provider: HTTP GET token/coin data
alt 404 Not Found
Provider-->>Route: 404 (token not in provider)
Note over Route: Silent — no logging
Route-->>Client: NextResponse 404
else 429 Rate Limited
Provider-->>Route: 429
Note over Route: Logger.warn + sentry
Route-->>Client: NextResponse 429
else Other error
Provider-->>Route: 5xx / other
Note over Route: Logger.panic
Route-->>Client: NextResponse error status
else 200 OK
Provider-->>Route: 200 + data
Route-->>Client: NextResponse 200 + data (cached)
end
Reviews (1): Last reviewed commit: "chore: build info" | Re-trigger Greptile |
| if (response.status === 429) { | ||
| Logger.warn('[api:coingecko] Rate limit exceeded', { sentry: true }); | ||
| } else { | ||
| } else if (response.status !== 404) { |
There was a problem hiding this comment.
Looks like we removed not only the logging to Sentry, but also the logging to Vercel. Could you please check?
Let's have warnings at Vercel for some time to monitor potential issues with searching for tokens/coins
4b5f442 to
a07310b
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
removed error logging for cases where token doesn't exist in a different verification provider. This is okay in case the token is new or still does not exist for a different provider. we have nothing to do with that
Type of change
Testing
n/a
Related Issues
n/a
Checklist
build:infoscript to update build information