Skip to content

feat: removed sentry logging for tokens 404 error#923

Merged
Woody4618 merged 4 commits intosolana-foundation:masterfrom
hoodieshq:sentry-for-404-removed
Apr 20, 2026
Merged

feat: removed sentry logging for tokens 404 error#923
Woody4618 merged 4 commits intosolana-foundation:masterfrom
hoodieshq:sentry-for-404-removed

Conversation

@C0mberry
Copy link
Copy Markdown
Contributor

@C0mberry C0mberry commented Apr 6, 2026

Description

removed error logging for cases where token doesn't exist in a different verification provider. This is okay in case the token is new or still does not exist for a different provider. we have nothing to do with that

Type of change

  • New feature

Testing

n/a

Related Issues

n/a

Checklist

  • My code follows the project's style guidelines
  • All tests pass locally and in CI
  • I have run build:info script to update build information
  • CI/CD checks pass

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2026

@C0mberry is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 6, 2026

Greptile Summary

This PR removes Logger.debug calls for 404 responses across the CoinGecko, Jupiter, and Rugcheck verification API routes, suppressing noisy logs when tokens are not found in a provider. The if/else restructuring in the coingecko and jupiter routes is logically equivalent to the original.

Confidence Score: 5/5

Safe to merge — all changes are minimal, logically correct, and reduce log noise as intended.

All remaining findings are P2 or below. The if/else restructuring in coingecko and jupiter routes is logically equivalent to the original; no data loss, security, or correctness issues are introduced. Rugcheck change is a one-line removal with no structural impact.

No files require special attention.

Important Files Changed

Filename Overview
app/api/verification/coingecko/[coinId]/route.ts Removed Logger.debug for 404 responses; restructured if/else to if (429) warn else if (!404) panic — logically equivalent to the original.
app/api/verification/jupiter/[mintAddress]/route.ts Same pattern as coingecko — 404s silently pass through; rate-limit warnings and panic on unexpected errors are preserved.
app/api/verification/rugcheck/[mintAddress]/route.ts Removed only the Logger.debug line in the 404 block; surrounding structure with special 400 'not found' handling is unchanged and correct.
bench/BUILD.md Minor build-size reference table numeric updates, unrelated to the logging change.

Sequence Diagram

sequenceDiagram
    participant Client
    participant Route as Verification API Route
    participant Provider as External Provider (CoinGecko/Jupiter/Rugcheck)

    Client->>Route: GET /api/verification/{provider}/{id}
    Route->>Provider: HTTP GET token/coin data
    alt 404 Not Found
        Provider-->>Route: 404 (token not in provider)
        Note over Route: Silent — no logging
        Route-->>Client: NextResponse 404
    else 429 Rate Limited
        Provider-->>Route: 429
        Note over Route: Logger.warn + sentry
        Route-->>Client: NextResponse 429
    else Other error
        Provider-->>Route: 5xx / other
        Note over Route: Logger.panic
        Route-->>Client: NextResponse error status
    else 200 OK
        Provider-->>Route: 200 + data
        Route-->>Client: NextResponse 200 + data (cached)
    end
Loading

Reviews (1): Last reviewed commit: "chore: build info" | Re-trigger Greptile

Comment thread bench/BUILD.md Outdated
if (response.status === 429) {
Logger.warn('[api:coingecko] Rate limit exceeded', { sentry: true });
} else {
} else if (response.status !== 404) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we removed not only the logging to Sentry, but also the logging to Vercel. Could you please check?
Let's have warnings at Vercel for some time to monitor potential issues with searching for tokens/coins

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

@rogaldh rogaldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C0mberry C0mberry force-pushed the sentry-for-404-removed branch from 4b5f442 to a07310b Compare April 14, 2026 12:43
@C0mberry C0mberry requested a review from rogaldh April 14, 2026 13:16
Copy link
Copy Markdown
Contributor

@rogaldh rogaldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer Ready Ready Preview, Comment Apr 20, 2026 0:13am

Request Review

@Woody4618 Woody4618 merged commit d27645c into solana-foundation:master Apr 20, 2026
6 of 7 checks passed
@rogaldh rogaldh deleted the sentry-for-404-removed branch April 20, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants