Skip to content

Support all types of mappings #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alxbilger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support all types of mappings #593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Mapping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,29 @@ namespace sofapython3
}

void moduleAddMapping(py::module &m) {
declareMapping<Rigid3dTypes, Vec3dTypes>(m);
declareMapping<Vec1dTypes, Vec1dTypes>(m);
Copy link
Contributor

@fredroy fredroy Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
declareMapping<Vec1dTypes, Vec1dTypes>(m);
declareMapping<Vec1Types, Vec1Types>(m);

I just do one just to show, and you will need to modify the alias before (using sofa::defaulttype::Vec1Types blabla)

Copy link
Contributor Author

@alxbilger alxbilger Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated to do that because depending on SReal, we don't end up with the same class name for the Python class (Mapping_Vec1d_Vec2d vs Mapping_Vec1f_Vec2f). Perhaps we can think about having a more generic name such as Mapping_Vec1_Vec2...

Copy link
Contributor Author

@alxbilger alxbilger Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The force field bindings also support only double

declareMapping<Vec1dTypes, Vec2dTypes>(m);
declareMapping<Vec1dTypes, Vec3dTypes>(m);

declareMapping<Vec2dTypes, Vec2dTypes>(m);
declareMapping<Vec2dTypes, Vec1dTypes>(m);

declareMapping<Vec3dTypes, Vec3dTypes>(m);
declareMapping<Vec3dTypes, Vec2dTypes>(m);
declareMapping<Vec3dTypes, Vec1dTypes>(m);

declareMapping<Vec6dTypes, Vec6dTypes>(m);
declareMapping<Vec6dTypes, Vec3dTypes>(m);
declareMapping<Vec6dTypes, Vec1dTypes>(m);

declareMapping<Rigid2dTypes, Vec2dTypes>(m);
declareMapping<Rigid2dTypes, Rigid2dTypes>(m);

declareMapping<Rigid3dTypes, Vec6dTypes>(m);
declareMapping<Rigid3dTypes, Vec3dTypes>(m);
declareMapping<Rigid3dTypes, Vec1dTypes>(m);
declareMapping<Rigid3dTypes, Rigid3dTypes>(m);
declareMapping<Vec3dTypes, Rigid3dTypes>(m);
}

} // namespace sofapython3
Loading