selector: Fail select() early when require_wgpu_xx finds no GPU adapter#11433
Open
selector: Fail select() early when require_wgpu_xx finds no GPU adapter#11433
Conversation
Before this change, calling require_wgpu_27()/require_wgpu_28() on a
system without a usable GPU adapter (e.g. a Windows VM with only the
DX12 Warp software adapter, or a host with no working GPU driver)
silently fell through to a non-wgpu renderer via the winit/linuxkms
fallback chain. Often that's the standalone software renderer, which
doesn't implement set_rendering_notifier, so the failure surfaced much
later as an Unsupported error from the rendering notifier callback,
typically inside application code that depends on the wgpu device.
Probe adapter availability inside BackendSelector::select_internal()
using the existing any_wgpu{27,28}_adapters_with_gpu helpers, and
return an error from select() before any backend is constructed. The
SLINT_WGPU_CPU=1 escape hatch still works because it short-circuits
the helper to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, calling require_wgpu_27()/require_wgpu_28() on a
system without a usable GPU adapter (e.g. a Windows VM with only the
DX12 Warp software adapter, or a host with no working GPU driver)
silently fell through to a non-wgpu renderer via the winit/linuxkms
fallback chain. Often that's the standalone software renderer, which
doesn't implement set_rendering_notifier, so the failure surfaced much
later as an Unsupported error from the rendering notifier callback,
typically inside application code that depends on the wgpu device.
Probe adapter availability inside BackendSelector::select_internal()
using the existing any_wgpu{27,28}_adapters_with_gpu helpers, and
return an error from select() before any backend is constructed. The
SLINT_WGPU_CPU=1 escape hatch still works because it short-circuits
the helper to true.