Re-factor and stabilize the grpc system test#1862
Open
gabordozsa wants to merge 2 commits intoskupperproject:mainfrom
Open
Re-factor and stabilize the grpc system test#1862gabordozsa wants to merge 2 commits intoskupperproject:mainfrom
gabordozsa wants to merge 2 commits intoskupperproject:mainfrom
Conversation
- Create a common base class for the non-TLS and TLS tests in order to avoid launching duplicate router and grpc server instances for the TLS tests - Disable fork support for grpcio in order to stabilize the test on CentOS 9 (python 3.9)
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI failure is related to the grpcio module which can have problem with fork() support in older python versions (python 3.9 in this case). The suggested fix is to disable fork support with a grpcio specific env var.
I also realized that the test launches duplicate router and grpc server instances for the TLS runs because of the inheritance structure between the two test classes. I factored-out. a common base class to fix that.
Fixes #1861