[Action] trigger generic harmful procs from energize_power effects#11253
[Action] trigger generic harmful procs from energize_power effects#11253
Conversation
It seems 'Generic Helpful' can be triggered by various resource energize effects from actions such that items & effects described as proccing off "heals" or have otherwise incorrect proc flags can trigger off harmful attacks and spells. action_t::suppress_callback_from_energize = true to disable for the action.
|
I believe this should resolve the issue described here: #11160 |
|
Think the only issue here that I see is that It will at least work intrinsically for ability |
engine/action/action.cpp
Outdated
| if ( callbacks && caster_callbacks && ( !suppress_caster_procs || enable_proc_from_suppressed ) && | ||
| !suppress_callback_from_energize ) | ||
| { | ||
| player->trigger_callbacks( PROC1_NONE_HELPFUL, PROC2_HIT, this, energize_state.get() ); |
There was a problem hiding this comment.
In follow-up to my comment on the main thread, I wonder if maybe this should just be moved into player_t::resource_gain instead, but only run if action_t* action is passed in? Many of the direct calls to resource_gain that are tied to an action pass in the action, similar to L5148 above.
e.g.
void actions::rogue_action_t<Base>::trigger_combo_point_gain( int cp, gain_t* gain )
{
p()->resource_gain( RESOURCE_COMBO_POINT, cp, gain, this );
}
Similar in priest_t::generate_insanity and most Runic Power gains.
It seems 'Generic Helpful' can be triggered by various resource energize effects from actions such that items & effects described as proccing off "heals" or have otherwise incorrect proc flags can trigger off harmful attacks and spells.
action_t::suppress_callback_from_energize = true to disable for the action.