fish: move MANPAGER to bat.fish, drop Solarized workaround#41
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Moves the MANPAGER configuration from the theme-specific fish config into the bat-specific config, now that Rosé Pine supports manpage highlighting and the Solarized workaround is no longer needed.
Changes:
- Remove the Solarized-based
MANPAGERoverride fromfish/conf.d/theme.fish. - Add a bat-based
MANPAGERdefinition tofish/conf.d/bat.fishwithout forcing a specific theme.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
fish/conf.d/theme.fish |
Drops the theme-specific MANPAGER Solarized workaround. |
fish/conf.d/bat.fish |
Centralizes MANPAGER under bat-related configuration using bat -lman. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simono
force-pushed
the
fix/rp-manpage-theme
branch
from
ed5a5b7 to
003a3eb
Compare
The Solarized theme override for man pages is no longer needed now that the upstream Rosé Pine tmTheme includes manpage scopes. MANPAGER is no longer theme-dependent, so move it to bat.fish. See rose-pine/tm-theme#9. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simono
force-pushed
the
fix/rp-manpage-theme
branch
from
003a3eb to
0495d98
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MANPAGER used Solarized as a workaround because Rosé Pine lacked manpage syntax highlighting scopes. Now that the upstream theme includes them (rose-pine/tm-theme#9), the override is unnecessary and MANPAGER can move to
bat.fishwhere it belongs.