Skip to content

SF-3733 Always show admins the number of unread answers#3718

Merged
Nateowami merged 2 commits intomasterfrom
fix/SF-3733-missing-answer-count
Mar 5, 2026
Merged

SF-3733 Always show admins the number of unread answers#3718
Nateowami merged 2 commits intomasterfrom
fix/SF-3733-missing-answer-count

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Mar 2, 2026

The unread count was not always being shown when it should. In particular, anyone with full access to the project should be able to see the unread counts.

Screenshot from 2026-03-02 12-42-09
Open with Devin

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Mar 2, 2026
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@21b7a96). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3718   +/-   ##
=========================================
  Coverage          ?   81.30%           
=========================================
  Files             ?      620           
  Lines             ?    39027           
  Branches          ?     6359           
=========================================
  Hits              ?    31732           
  Misses            ?     6312           
  Partials          ?      983           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the fix/SF-3733-missing-answer-count branch 2 times, most recently from c7c25c7 to f23727d Compare March 3, 2026 03:00
devin-ai-integration[bot]

This comment was marked as resolved.

@Nateowami Nateowami force-pushed the fix/SF-3733-missing-answer-count branch from f23727d to 96c01a6 Compare March 3, 2026 03:20
@Nateowami Nateowami force-pushed the fix/SF-3733-missing-answer-count branch from 96c01a6 to 3acd9c3 Compare March 3, 2026 15:00
@pmachapman pmachapman self-assigned this Mar 3, 2026
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Mar 3, 2026
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Mar 5, 2026
@Nateowami Nateowami enabled auto-merge (squash) March 5, 2026 15:52
@Nateowami Nateowami merged commit 5bc0146 into master Mar 5, 2026
22 checks passed
@Nateowami Nateowami deleted the fix/SF-3733-missing-answer-count branch March 5, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants