Skip to content

SF-3722 Fix errors on format options when no source access#3715

Open
pmachapman wants to merge 1 commit intomasterfrom
fix/SF-3722
Open

SF-3722 Fix errors on format options when no source access#3715
pmachapman wants to merge 1 commit intomasterfrom
fix/SF-3722

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 1, 2026

This PR updates the draft USFM format options page to show a warning if the user cannot access the source project, and only allow access to the first chapter.


Open with Devin

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Mar 1, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.33%. Comparing base (13dc661) to head (c4417e3).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3715   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         620      620           
  Lines       39037    39046    +9     
  Branches     6364     6342   -22     
=======================================
+ Hits        31749    31758    +9     
- Misses       6304     6318   +14     
+ Partials      984      970   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman force-pushed the fix/SF-3722 branch 2 times, most recently from 1621063 to 85bde82 Compare March 2, 2026 22:15
@Nateowami
Copy link
Collaborator

Why do we need access to the source in order to show the draft?

@pmachapman
Copy link
Collaborator Author

Why do we need access to the source in order to show the draft?

@Nateowami To get the list of valid chapters for the draft (we can't use the versification to calculate this in the frontend).

@Nateowami
Copy link
Collaborator

Why can't we fetch the draft from the back end and see how many chapters are in it?

@pmachapman
Copy link
Collaborator Author

Why can't we fetch the draft from the back end and see how many chapters are in it?

@Nateowami We retrieve each chapter individually. If we were to fetch the whole draft, we would need a way to parse the USFM and calculate the number of chapters on the frontend. We also can't use the versification to figure out the chapters on the frontend (as is is not present there), so we would likely need some new endpoint just to get the number of chapters. The simplest way is just to see the numbers of chapters in the source USFM, as these should match the chapters drafted.

@marksvc marksvc self-assigned this Mar 5, 2026
@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Mar 9, 2026
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 7 additional findings in Devin Review.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants