mod_spandsp fax_header and fax_ident _undef_ not being respected#2890
Open
MayamaTakeshi wants to merge 1 commit intosignalwire:masterfrom
Open
mod_spandsp fax_header and fax_ident _undef_ not being respected#2890MayamaTakeshi wants to merge 1 commit intosignalwire:masterfrom
MayamaTakeshi wants to merge 1 commit intosignalwire:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation (https://developer.signalwire.com/freeswitch/FreeSWITCH-Explained/Modules/mod_spandsp_6587021/)
we can suppress the fax header line (txfax) if we set
However, the code in mod_spandsp_fax.c doesn't have code to handle this (neither for fax_ident):
freeswitch/src/mod/applications/mod_spandsp/mod_spandsp_fax.c
Line 1433 in d22aec6
So the fax is sent with header and ident as:
The value
only works in the general configuration of mod_spandsp parameters header and ident:
This PR addresses this issue.