Skip to content

FcmRefreshJob: Attempt token retrieval before checking GMS status#14716

Open
insaneodyssey26 wants to merge 1 commit intosignalapp:mainfrom
insaneodyssey26:fix/fcm-gms-resilience-14662
Open

FcmRefreshJob: Attempt token retrieval before checking GMS status#14716
insaneodyssey26 wants to merge 1 commit intosignalapp:mainfrom
insaneodyssey26:fix/fcm-gms-resilience-14662

Conversation

@insaneodyssey26
Copy link
Copy Markdown

Currently, FcmRefreshJob fails immediately if isGooglePlayServicesAvailable returns a non-success code. This causes persistent "Signal was unable to register" notifications on environments like Android 16 or certain custom firmwares where GMS is actually functional enough to provide a token.
This change switches to a "try-first" approach:

  1. Attempt to get the FCM token first.
  2. If successful, proceed with registration (ignoring GMS status).
  3. Only show the failure notification if token retrieval fails and GMS availability confirms a real error.

Fixes #14662

@greyson-signal
Copy link
Copy Markdown
Contributor

greyson-signal commented Apr 13, 2026

So is the idea that there are devices that could give us an FCM token while simultaneously reporting Google Play Services as unavailable?

@insaneodyssey26
Copy link
Copy Markdown
Author

So is the idea that there are devices that could give us an FCM token while simultaneously reporting Google Play Services as unavailable?

Yes... More like an Android 16 environment specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal doesn't detect Google Play Services

2 participants