FcmRefreshJob: Attempt token retrieval before checking GMS status#14716
Open
insaneodyssey26 wants to merge 1 commit intosignalapp:mainfrom
Open
FcmRefreshJob: Attempt token retrieval before checking GMS status#14716insaneodyssey26 wants to merge 1 commit intosignalapp:mainfrom
insaneodyssey26 wants to merge 1 commit intosignalapp:mainfrom
Conversation
Contributor
|
So is the idea that there are devices that could give us an FCM token while simultaneously reporting Google Play Services as unavailable? |
Author
Yes... More like an Android 16 environment specific issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, FcmRefreshJob fails immediately if isGooglePlayServicesAvailable returns a non-success code. This causes persistent "Signal was unable to register" notifications on environments like Android 16 or certain custom firmwares where GMS is actually functional enough to provide a token.
This change switches to a "try-first" approach:
Fixes #14662