Remove more unused pieces#14672
Closed
JesseWeinstein wants to merge 33 commits intosignalapp:mainfrom
Closed
Conversation
JesseWeinstein
force-pushed
the
remove_more_unused
branch
from
b32bad1 to
36530c3
Compare
JesseWeinstein
changed the title
JesseWeinstein
changed the title
Contributor
Author
|
I'll keep adding more to this PR as I find them, until I get a note that it will be included in the next version. :-) This is anything but urgent, so take as long as is needed. |
JesseWeinstein
force-pushed
the
remove_more_unused
branch
from
757435c to
0ef0b92
Compare
The last import was removed in signalapp@bece58d and the last actual use in signalapp@bcc5d48
Last use removed in signalapp@96333b6
It was extracted to a separate file in March 2024 in signalapp@c53abe0 It was renamed from FileVideoInput in May 2020 in signalapp@3db5da1 But it was originally introduced in Feb 2020 in signalapp@40fd7ca#diff-187e1f629a40c77f9ddca2c20bf542945f425e29e32cbc4cfb0dea0516e4c459 ... and never used in that commit, or any later one.
whose last use was removed in 2019 Last import removed in May 2020 in signalapp@310ec8f Last use was removed in July 2019 signalapp@965de16
Last use removed in signalapp@5d6d78a
…d in Jul 2021 Last use removed in signalapp@5d6d78a
Last use removed in signalapp@dc9b816
Last (and only) use removed in signalapp@aa76cef
… was last used in Jan 2023 In commit ef9cd25
…lowing the removal of HtmlUtil
It was added in commit fb82420
…ed in Sept 2024 In commit ba06efe
JesseWeinstein
force-pushed
the
remove_more_unused
branch
from
b26c82e to
cf4f6d5
Compare
Contributor
|
Thnks for the effort! |
Contributor
|
Thanks! Will be in 8.8 |
greyson-signal
approved these changes
Apr 10, 2026
Contributor
Author
|
Wonderful! I'll add any more I find to a new PR. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
Removing more unused classes/methods -- some that were never used, and one that was last used in 2012 (over a decade ago!)