Add an indicator in the conversation list for unread reactions#14359
Open
michaelstambach wants to merge 6 commits intosignalapp:mainfrom
Open
Add an indicator in the conversation list for unread reactions#14359michaelstambach wants to merge 6 commits intosignalapp:mainfrom
michaelstambach wants to merge 6 commits intosignalapp:mainfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # app/src/main/java/org/thoughtcrime/securesms/database/MessageTable.kt # app/src/main/java/org/thoughtcrime/securesms/database/helpers/SignalDatabaseMigrations.kt
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # app/src/main/java/org/thoughtcrime/securesms/database/helpers/SignalDatabaseMigrations.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
This commit adds an indicator to the conversation list for conversations with unread reactions. Currently, if a reaction to message is received a notification is sent but inside the app there is no way to see from which chat this notification arrived. This PR changes this so that a small heart is displayed next to the unread indicator if there was a reaction to an outgoing message.
The indicator is not shown if there are also unread mentions to save space.
I tried to implement this similarly to how the unread mentions indicator is implemented. This required adding a new column to the thread table to track the reactions to the users own messages. This is my first time contributing to this project so I hope I have done everything as intended. I tested my changes and they seem to work as intended.
See the image below for an example of the indicator showing reactions on chats.
