fix/enable simple html inline css#902
Merged
s-brankovic merged 2 commits intodevelopfrom Feb 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inline CSS styles not being applied (React 19 compatibility)
Problem
Inline
style=""attributes in HTML content rendered bySimpleHtmlare silently ignored on native devices. This means any HTML with inline styling (colors, text-align, background-color, font-size, etc.) renders without those styles.Root Cause
react-native-render-htmlv6.3.4 relies ondefaultPropsto set default values for itsTRenderEngineProvidercomponent, includingenableCSSInlineProcessing: true. React 19 (shipped with RN 0.78) completely removed support fordefaultPropson function components, causing these defaults to becomeundefined. WhenenableCSSInlineProcessingisundefined(falsy), the transient render engine skips all inline style parsing.Fix
Explicitly pass the three most impactful
TRenderEngineProviderdefaults inSimpleHtml'shtmlProps:enableCSSInlineProcessing: true— required, without this all inline styles are ignoredenableUserAgentStyles: true— ensures user-agent styles apply (e.g.,<b>renders bold,<em>renders italic)emSize: 14— ensuresem/remCSS units resolve correctlyThe remaining defaults (
classesStyles,ignoredDomTags,htmlParserOptions,fallbackFonts) have built-in fallbacks in the library's internal code (buildTREFromConfig.js) and don't require explicit overrides.Other internal components using
defaultProps(TNodeRenderer,TChildrenRenderer,TNodeChildrenRenderer) were verified safe — their compiled code uses optional chaining or JS default parameters, preventing crashes whendefaultPropsis stripped.We also considered using the existing patches recommended in the issues bellow , but decided they were an overhaul for our specific use case.
References
enableCSSInlineProcessing: truedefaultPropsdeprecationdefaultPropswith JS default parameters (9500+ line diff, unmerged)react-native-render-htmlis being deprecated in favor of@native-html/render(alpha, co-maintained by Software Mansion) - We might consider switching to this package in the future when out of alfa.