feat: added docs for custom HTTP client injection for S3 client creation#2187
Open
Arjan Lankhaar (lankhaar) wants to merge 1 commit intoshopware:mainfrom
Open
feat: added docs for custom HTTP client injection for S3 client creation#2187Arjan Lankhaar (lankhaar) wants to merge 1 commit intoshopware:mainfrom
Arjan Lankhaar (lankhaar) wants to merge 1 commit intoshopware:mainfrom
Conversation
5 tasks
Arjan Lankhaar (lankhaar)
force-pushed
the
feat/s3-custom-http-client
branch
from
760eb16 to
8a826ef
Compare
Arjan Lankhaar (lankhaar)
requested review from
Michael Telgmann (mitelg) and
Umut Dogan (umutdogan4291)
Umut Dogan (umutdogan4291)
requested changes
Mar 13, 2026
Contributor
Umut Dogan (umutdogan4291)
left a comment
Umut Dogan (umutdogan4291)
left a comment
There was a problem hiding this comment.
Thank you.
Arjan Lankhaar (lankhaar)
force-pushed
the
feat/s3-custom-http-client
branch
from
8a826ef to
5d171a3
Compare
Arjan Lankhaar (lankhaar)
force-pushed
the
feat/s3-custom-http-client
branch
from
5d171a3 to
ac48f35
Compare
Arjan Lankhaar (lankhaar)
force-pushed
the
feat/s3-custom-http-client
branch
from
ac48f35 to
83a69b8
Compare
Umut Dogan (umutdogan4291)
approved these changes
Mar 13, 2026
Michael Telgmann (mitelg)
approved these changes
Mar 13, 2026
Michael Telgmann (mitelg)
requested changes
Mar 13, 2026
|
|
||
| #### Custom HTTP client for S3 | ||
|
|
||
| By default, the underlying AsyncAws S3 client creates its own HTTP client internally, which includes a `RetryableHttpClient` with an AWS-specific retry strategy. This handles transient errors like throttling (HTTP 429), server errors (HTTP 5xx), and other AWS-specific error codes automatically. |
There was a problem hiding this comment.
we should add a ::: info block to inform since when this will be available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to this PR