investment in unix x86_64 path parity#174
Closed
brandonros wants to merge 1 commit intosha0coder:mainfrom
Closed
Conversation
a145b85 to
8269f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses parts of #160
Summary
This brings the Unix x86_64 paths much closer to parity by wiring up the missing loader, syscall, and API-interception pieces for:
It also hardens the existing macOS AArch64 hello coverage and adds focused fixtures/tests for the new x86_64 paths.
What changed
Shared API ABI handling
macOS x86_64 support
syscallthrough a macOS syscall gateway instead of falling into the Windows pathset_rip()Linux x86_64 support
maps/maps_linuxlibc.so.6DT_NEEDEDDT_RELADT_JMPRELR_X86_64_GLOB_DATR_X86_64_JUMP_SLOTset_rip()__libc_start_mainstartup bridge for the dynamic hello-world pathTests
_start__libc_start_mainmainputsexitTooling / repo support
Validation
Ran:
cargo check -p libmwemu --target x86_64-apple-darwincargo test -p libmwemu macho64 --target x86_64-apple-darwin -- --nocapturecargo test -p libmwemu elf64lin_dynamic_hello --target x86_64-apple-darwin -- --nocaptureNotes
todo!()and remain follow-up work.