Don't try to minify a BinaryFileResponse#1
Open
eab-andy wants to merge 1 commit intosergeysemko:masterfrom
Open
Don't try to minify a BinaryFileResponse#1eab-andy wants to merge 1 commit intosergeysemko:masterfrom
eab-andy wants to merge 1 commit intosergeysemko:masterfrom
Conversation
|
The same problem happens with a So it should be if ( $response instanceof BinaryFileResponse ||
$response instanceof StreamedResponse )
return;I think those are the only two Response types where the content cannot be set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't try to minify a BinaryFileResponse, otherwise you will get the error:
"LogicException(code: 0): The content cannot be set on a BinaryFileResponse instance"