Skip to content

Don't try to minify a BinaryFileResponse#1

Open
eab-andy wants to merge 1 commit intosergeysemko:masterfrom
eab-dev:FixBinaryFileResponse
Open

Don't try to minify a BinaryFileResponse#1
eab-andy wants to merge 1 commit intosergeysemko:masterfrom
eab-dev:FixBinaryFileResponse

Conversation

@eab-andy
Copy link
Copy Markdown

Don't try to minify a BinaryFileResponse, otherwise you will get the error:

"LogicException(code: 0): The content cannot be set on a BinaryFileResponse instance"

@fritzmg
Copy link
Copy Markdown

fritzmg commented Aug 4, 2016

The same problem happens with a StreamedResponse:

LogicException: "The content cannot be set on a StreamedResponse instance."

So it should be

if ( $response instanceof BinaryFileResponse ||
     $response instanceof StreamedResponse )
    return;

I think those are the only two Response types where the content cannot be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants