Fix deserializing adjacently tagged unit variants as sequences#3062
Draft
boomshroom wants to merge 1 commit intoserde-rs:masterfrom
Draft
Fix deserializing adjacently tagged unit variants as sequences#3062boomshroom wants to merge 1 commit intoserde-rs:masterfrom
boomshroom wants to merge 1 commit intoserde-rs:masterfrom
Conversation
This behavior is copied from the map visitor where this was already fixed.
Author
|
Seems this is more complex than I thought. The map version checks if the next field exists before handing over the variant to the seed, but the sequence version uses the variant before it gets the presence of a second field. If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior is copied from the map visitor where this was already fixed.
Partially addresses #1762 and 3Hren/msgpack-rust#250. Resolving the struct variant part of the issue will be more tricky due to its codepath involving the untagged variants logic where the current behavior is more desirable.