remove 'Content-Encoding' header when returning responses#14
Merged
kmike merged 1 commit intozyte-api-responsefrom May 11, 2022
Merged
remove 'Content-Encoding' header when returning responses#14kmike merged 1 commit intozyte-api-responsefrom
kmike merged 1 commit intozyte-api-responsefrom
Conversation
Member
|
The fix makes sense to me, though argument could be made that it's actually an issue with Zyte API: httpResponseBody is not a raw response, it's returned after content-encoding applied. So, our options:
from these options, I like (2) the most. @akshayphilar any preference from you? |
|
@kmike agree, the second approach makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11. Built on top of #10.
Lots of approach to fix it but it would seem that this is the simplest one. The only downside is that the response instance returned to Scrapy doesn't have the accurate representation of the complete headers since
Content-Encodingis removed. However, that should be okay since we're preserving it anyways inresponse.zyte_api_response.headers.