Skip to content

[Snyk] Security upgrade django from 3.2.25 to 4.2.26 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade django from 3.2.25 to 4.2.26 #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements/local.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ django-extensions==3.2.3 # https://github.com/django-extensions/django-extensio
django-coverage-plugin==3.1.0 # https://github.com/nedbat/django_coverage_plugin
pytest-django==4.7.0 # https://github.com/pytest-dev/pytest-django
tornado>=6.4.1 # not directly required, pinned by Snyk to avoid a vulnerability
django>=4.2.26 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding django>=4.2.26 to local.txt creates a dependency conflict. Django 3.2.x is likely pinned in a base requirements file (e.g., base.txt or production.txt), but this adds a conflicting constraint requiring 4.2.26+. This is a major version upgrade (3.2→4.2) that requires updating the primary Django dependency declaration and testing for breaking changes, not just adding a constraint in local.txt. The PR should update the main Django requirement instead of adding a duplicate constraint.

Suggested change
django>=4.2.26 # not directly required, pinned by Snyk to avoid a vulnerability

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'not directly required' is misleading since Django is clearly a direct dependency of this project (as indicated by django-extensions requiring it). The comment should accurately reflect that this is upgrading an existing Django dependency for security reasons.

Suggested change
django>=4.2.26 # not directly required, pinned by Snyk to avoid a vulnerability
django>=4.2.26 # direct dependency; version pinned/upgraded for security reasons

Copilot uses AI. Check for mistakes.