chore(licenses):SP-4211 Add err_message and error_code fields to Comp…#68
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdd per-component error reporting and richer license metadata: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
protobuf/scanoss/api/licenses/v2/README.md (1)
130-148: Clarify top-level status semantics in this section.Consider adding one sentence that
status: "SUCCESS"means the request was processed, while per-component failures are conveyed viaerror_code/error_message. That avoids client-side misinterpretation.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@protobuf/scanoss/api/licenses/v2/README.md` around lines 130 - 148, In the "Error in component" section of the README add a single clarifying sentence after the JSON example stating that the top-level status (e.g., "status": "SUCCESS") indicates the overall request was processed, while per-component failures are reported via the component's error_code and error_message fields so clients should not treat a SUCCESS top-level status as every component succeeded.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 10-14: Change the dated release header in CHANGELOG.md that
currently reads "## [0.34.0] - 2026-03-31" to use an "Unreleased" header instead
(e.g., "## [Unreleased]" or "## [0.34.0] - Unreleased") so pending changes are
not pre-dated; update the same block that lists the two Added items (the
`error_message`/`error_code` addition and the README example) and ensure any
release tooling references the Unreleased section until the real release date.
---
Nitpick comments:
In `@protobuf/scanoss/api/licenses/v2/README.md`:
- Around line 130-148: In the "Error in component" section of the README add a
single clarifying sentence after the JSON example stating that the top-level
status (e.g., "status": "SUCCESS") indicates the overall request was processed,
while per-component failures are reported via the component's error_code and
error_message fields so clients should not treat a SUCCESS top-level status as
every component succeeded.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 606ceb10-3c10-43de-9d2e-7d353b6ac87f
⛔ Files ignored due to path filters (1)
api/licensesv2/scanoss-licenses.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (4)
CHANGELOG.mdprotobuf/scanoss/api/licenses/v2/README.mdprotobuf/scanoss/api/licenses/v2/scanoss-licenses.protoprotobuf/scanoss/api/licenses/v2/scanoss-licenses.swagger.json
…onentLicenseInfo message
…es/components and licenses/component responses
538cd04 to
685bbe8
Compare
…onentLicenseInfo message
Summary by CodeRabbit
New Features
Documentation