Fix negative decimal handling across all languages#646
Open
jqueguiner wants to merge 1 commit intosavoirfairelinux:masterfrom
Open
Fix negative decimal handling across all languages#646jqueguiner wants to merge 1 commit intosavoirfairelinux:masterfrom
jqueguiner wants to merge 1 commit intosavoirfairelinux:masterfrom
Conversation
jqueguiner
commented
Jan 17, 2026
- Fixed num2words(-0.4) returning 'zero point four' instead of 'minus zero point four'
- Added proper negative handling to 17 language implementations (AM, BE, BN, CE, CS, CY, HE, JA, KZ, MN, PL, RU, SK, SR, TR, UK, VI)
- Added comprehensive test coverage for negative decimals (-0.4, -0.5, -1.4, -10.25) across all 62 supported languages
- Fixed language-specific implementations that override to_cardinal or to_cardinal_float methods
- Ensured negative sign preservation for decimals with zero integer part (e.g., -0.4)
- All tests passing with linguistically correct outputs for each language
- Fixed num2words(-0.4) returning 'zero point four' instead of 'minus zero point four' - Added proper negative handling to 17 language implementations (AM, BE, BN, CE, CS, CY, HE, JA, KZ, MN, PL, RU, SK, SR, TR, UK, VI) - Added comprehensive test coverage for negative decimals (-0.4, -0.5, -1.4, -10.25) across all 62 supported languages - Fixed language-specific implementations that override to_cardinal or to_cardinal_float methods - Ensured negative sign preservation for decimals with zero integer part (e.g., -0.4) - All tests passing with linguistically correct outputs for each language 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.