Add to_ordinal implementation for Czech. Fix to_ordinal for Korean#640
Open
polariton wants to merge 2 commits intosavoirfairelinux:masterfrom
Open
Add to_ordinal implementation for Czech. Fix to_ordinal for Korean#640polariton wants to merge 2 commits intosavoirfairelinux:masterfrom
polariton wants to merge 2 commits intosavoirfairelinux:masterfrom
Conversation
added 2 commits
July 10, 2025 13:23
- There should be no space after 백 (hundred) because Korean numbers are written as compound words without spaces. - Handle place values properly: Check if the number ends with 백, 천, 만, 억 first. - Handle 십 (ten) properly. - Use proper string splitting with limit parameter. - Use .get() method instead of try/except for dictionary lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Status
How to verify this change
Test Czech and Korean ordinals as follows:
Additional notes
I introduced these changes to properly convert ordinal numbers in Czech and Korean for creating the multilanguage speech datasets with CoquiTTS.