Fixed Currency to only Display Cents When Needed#602
Open
cheng-jess wants to merge 7 commits intosavoirfairelinux:masterfrom
Open
Fixed Currency to only Display Cents When Needed#602cheng-jess wants to merge 7 commits intosavoirfairelinux:masterfrom
cheng-jess wants to merge 7 commits intosavoirfairelinux:masterfrom
Conversation
Contributor
Author
|
@mrodriguezg1991 Tagging for review per Mohammed's email. Thank you. |
Contributor
Hello @cheng-jess , thanks for contributing |
Contributor
|
@mrodriguezg1991 It looks like this is failing due to the Amharic cardinal test cases (28-33 in test_am.py)--these don't appear to be related to the cents issue. @cheng-jess what's the purpose of these test cases? I am also interested in getting this issue resolved. 🙂 |
Contributor
|
Oh it looks like it's related to @cheng-jess 's other PR here, probably these cases were meant to go there. |
Contributor
|
I opened a new PR here which removes the erroneous test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554 by updating base.py
Changes proposed in this pull request:
Status
How to verify this change
Additional notes
Not sure if this issue was a wanted bug fix or feature, but updated base.py to stop cents from being converted to words when not explicitly included in the number input (e.g. handling 100 vs 100.00 differently).