Normalize is-tiled-image attribute string to boolean.#325
Open
markpbaggett wants to merge 1 commit intosamvera-labs:mainfrom
Open
Normalize is-tiled-image attribute string to boolean.#325markpbaggett wants to merge 1 commit intosamvera-labs:mainfrom
markpbaggett wants to merge 1 commit intosamvera-labs:mainfrom
Conversation
HTML attributes are always strings, so "false" is always being treated as "truthy." This causes the web component to always fetch info.json in tiled image mode. Instead, this change explicitly compares against true/"true" to correctly handle all attribute values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML attributes are always strings, so "false" is always is evaluated as "true" when using image in Vanilla JS.
As the code is currently, this causes the web component (clover-image) to always fetch info.json in tiled image mode. To stop this, this change explicitly compares against true/"true" to correctly handle boolean-like attribute values in Vanilla JS.