Refactor panel visibility logic#307
Open
body-clock wants to merge 11 commits intosamvera-labs:mainfrom
Open
Conversation
body-clock
commented
Oct 21, 2025
| availableTabs.includes(String(informationPanel.defaultTab)) && | ||
| informationPanel.defaultTab) || | ||
| availableTabs[0] || | ||
| "manifest-about"; |
Author
There was a problem hiding this comment.
Wondering about this - is it worth falling back to a tab that just says something like "No tabs configured, consider adding one or disabling the toggle". Or maybe just disabling the toggle in this case?
Member
|
Hi @body-clock. I've taken a peek at this and am seeing some issues with it automatically toggling back to the About tab if I attempted navigate to Annotations. I'll take a deeper look at other use cases but these are the two obvious ones I noted. For example, try wiring up either of these resources: vtt annotations for this item content state link for this item (with an annotation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #306
pluginsWithInfoPanelfromInformationPaneltoViewer/Content(which rendersInformationPanel), pass it as a prop (so it isn't called twice)