[master] Add extra_args Parameter to pip.uninstall Module Function#65871
Open
cianyleow wants to merge 2 commits intosaltstack:masterfrom
Open
[master] Add extra_args Parameter to pip.uninstall Module Function#65871cianyleow wants to merge 2 commits intosaltstack:masterfrom
extra_args Parameter to pip.uninstall Module Function#65871cianyleow wants to merge 2 commits intosaltstack:masterfrom
Conversation
salt-project-bot-prod-environment
bot
changed the title
extra_args Parameter to pip.uninstall Module Functionextra_args Parameter to pip.uninstall Module Function
cianyleow
force-pushed
the
add-pip-uninstall-extra-args
branch
2 times, most recently
from
5a9dea2 to
b241df5
Compare
cianyleow
force-pushed
the
add-pip-uninstall-extra-args
branch
from
b241df5 to
f8c491f
Compare
twangboy
requested changes
May 13, 2025
Contributor
twangboy
left a comment
twangboy
left a comment
There was a problem hiding this comment.
Just need to add .. versionadded:: 3008 to the new argument docs. Also, a rebase would be good.
twangboy
approved these changes
Mar 19, 2026
Adds the existing extra_args logic for the install function in the pip module to the uninstall function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the existing
extra_argslogic for theinstallfunction in thepipmodule to theuninstallfunction.What issues does this PR fix or reference?
Addresses the issue in #65870
Previous Behavior
The
pip.uninstallfunction did not support theextra_argsparameterNew Behavior
The
pip.uninstallfunction now supports theextra_argsparameterMerge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.