Open
Conversation
Note: this patch changes collectd's behaviour if grains['fqdn'] is not
the same as the output of hostname -f. Restore the old behaviour by
setting this in the collectd piller:
Hostname: {{ salt['grains.get']('fqdn') }}
With this patch Hostname is only set in collectd.conf if it is set in
the pillar data. If it is not set collectd will determine it using
gethostname(2). FQDNLookup is set in collectd.conf as follow:
- Hostname set: FQDNLookup not set (would be ignored by collectd)
- Hostname not set: FQDNLookup set from pillar data or default true
Contributor
|
Hi @hwhesselink Is this PR still needed with version 5 since it defaults to true? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.