@W-21740433 - feat: add PdpEvent type and sendPdpEvent method to TelemetryService#431
Open
aruntyagiTutu wants to merge 2 commits intomainfrom
Open
@W-21740433 - feat: add PdpEvent type and sendPdpEvent method to TelemetryService#431aruntyagiTutu wants to merge 2 commits intomainfrom
aruntyagiTutu wants to merge 2 commits intomainfrom
Conversation
Adds Product Feedback Telemetry (PFT) support to the MCP Provider API to enable PDP event reporting across all MCP provider packages. Changes: - Added PdpEvent type with template literal constraints: * eventName: enforces "object.action" format (e.g., "codeAnalyzer.run") * productFeatureId: enforces GUS Product Feature ID format (aJC prefix) * componentId: optional component identifier * eventVolume: optional volume metric - Added sendPdpEvent() method to TelemetryService interface - Exported PdpEvent type from package index The PdpEvent type aligns with @salesforce/telemetry package's type definitions, ensuring type safety and compatibility with O11y telemetry infrastructure. This API change enables provider packages to send PFT events for product analytics and usage tracking.
Updates NoopTelemetryService to implement the new sendPdpEvent() method added to the TelemetryService interface. This ensures all implementations of TelemetryService properly implement the PDP event reporting capability. Changes: - Added PdpEvent import from @salesforce/mcp-provider-api - Implemented sendPdpEvent() method in NoopTelemetryService class as no-op
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Product Feedback Telemetry (PFT) support to the MCP Provider API to enable PDP event reporting across all MCP provider packages.
Changes:
The PdpEvent type aligns with @salesforce/telemetry package's type definitions, ensuring type safety and compatibility with O11y telemetry infrastructure.
This API change enables provider packages to send PFT events for product analytics and usage tracking.
What does this PR do?
What issues does this PR fix or reference?