Skip to content

SAK-52355 Microsoft - Add the posibility to enable a new forced synchronization in Microsoft Team for the site#283

Draft
jesusmmp wants to merge 1 commit intomasterfrom
SAK-52355
Draft

SAK-52355 Microsoft - Add the posibility to enable a new forced synchronization in Microsoft Team for the site#283
jesusmmp wants to merge 1 commit intomasterfrom
SAK-52355

Conversation

@jesusmmp
Copy link
Copy Markdown
Contributor

@jesusmmp jesusmmp commented Mar 31, 2026

https://sakaiproject.atlassian.net/browse/SAK-52355

Summary by CodeRabbit

  • Database Migrations
    • Updated database schema for MySQL and Oracle environments to add support for disabling site synchronization.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026

Walkthrough

Added database schema migrations for both MySQL and Oracle that introduce a non-nullable DISABLED column with default value of 0 to the MC_SITE_SYNCHRONIZATION table as part of issue SAK-52355.

Changes

Cohort / File(s) Summary
Database Migrations (SAK-52355)
docs/conversion/sakai_26_mysql_conversion.sql, docs/conversion/sakai_26_oracle_conversion.sql
Added DISABLED column to MC_SITE_SYNCHRONIZATION table with database-specific syntax (BIT type for MySQL, NUMBER(1,0) for Oracle), both with default value 0 and NOT NULL constraint.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references SAK-52355 and describes adding forced synchronization capability for Microsoft Teams, which aligns with the PR's database schema changes adding a DISABLED column to MC_SITE_SYNCHRONIZATION.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch SAK-52355

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/conversion/sakai_26_mysql_conversion.sql`:
- Around line 29-31: The ALTER uses upper-case table name
"MC_SITE_SYNCHRONIZATION" which doesn't match the original lowercase creation
"mc_site_synchronization"; update the ALTER statement in
sakai_26_mysql_conversion.sql to use the exact lowercase table identifier
mc_site_synchronization (i.e., replace ALTER TABLE MC_SITE_SYNCHRONIZATION ADD
DISABLED ... with ALTER TABLE mc_site_synchronization ADD DISABLED ...) so
case-sensitive MySQL deployments succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09d780b7-d421-4f6a-8dc6-821908571d31

📥 Commits

Reviewing files that changed from the base of the PR and between f5606c0 and 8ddf405.

📒 Files selected for processing (2)
  • docs/conversion/sakai_26_mysql_conversion.sql
  • docs/conversion/sakai_26_oracle_conversion.sql

Comment thread docs/conversion/sakai_26_mysql_conversion.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant