Skip to content

test: exercise zstd compression #39

Merged
quettabit merged 1 commit intomainfrom
qb/compres-test
Apr 23, 2026
Merged

test: exercise zstd compression #39
quettabit merged 1 commit intomainfrom
qb/compres-test

Conversation

@quettabit
Copy link
Copy Markdown
Member

No description provided.

@quettabit quettabit requested a review from a team as a code owner April 23, 2026 21:13
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

This PR extends the integration test class TestCompression to also run against Compression.ZSTD in addition to the existing Compression.GZIP parametrization, exercising both the unary and session append/read roundtrip paths with zstd compression.

Confidence Score: 5/5

Safe to merge — trivial one-line addition to test parametrization with no logic changes.

Compression.ZSTD is already fully implemented and exercised at unit level throughout the SDK. This change simply ensures the integration test suite also covers the ZSTD path. No production code is modified.

No files require special attention.

Important Files Changed

Filename Overview
tests/test_stream_ops.py Single-line change adds Compression.ZSTD to the parametrize decorator, causing both compression integration tests to run for ZSTD as well as GZIP. No issues found.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    P["@pytest.mark.parametrize\n[Compression.GZIP, Compression.ZSTD]"]
    P --> T1["test_compression_roundtrip_unary(GZIP)"]
    P --> T2["test_compression_roundtrip_unary(ZSTD)"]
    P --> T3["test_compression_roundtrip_session(GZIP)"]
    P --> T4["test_compression_roundtrip_session(ZSTD)"]
    T1 --> A1["append records\n(S2 client, gzip)"]
    T2 --> A2["append records\n(S2 client, zstd)"]
    T3 --> A3["append_session\n(S2 client, gzip)"]
    T4 --> A4["append_session\n(S2 client, zstd)"]
    A1 --> R1["read & assert records match"]
    A2 --> R2["read & assert records match"]
    A3 --> R3["read_session & assert records match"]
    A4 --> R4["read_session & assert records match"]
Loading

Reviews (1): Last reviewed commit: "initial commit" | Re-trigger Greptile

@quettabit quettabit merged commit 987d585 into main Apr 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant