fix: preserve assistant responses in chat history#8
Open
akdenizemirhan wants to merge 1 commit intoryanstephen:mainfrom
Open
fix: preserve assistant responses in chat history#8akdenizemirhan wants to merge 1 commit intoryanstephen:mainfrom
akdenizemirhan wants to merge 1 commit intoryanstephen:mainfrom
Conversation
Streaming text from Claude's responses was not being saved to the session history. When the popover closed and reopened, only user messages appeared - assistant responses were lost. The root cause: Claude CLI returns streaming text via "assistant" type messages, but the "result" type message has an empty "result" field. The history was only populated from the "result" field, so responses were never saved. Fix: accumulate streaming text during the assistant response and save it to history when the turn completes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replayHistory()only showed user messages, not Claude's responsesRoot Cause
Claude CLI sends responses as streaming
"assistant"type messages, but the final"result"type message has an empty"result"field. The history was only populated fromresult.result, so responses were never persisted.Fix
currentStreamingResponseduring assistant messages"result"event)Test plan
🤖 Generated with Claude Code