Pr/pop out chat - to allow for long running tasks to have their dedicated window#49
Open
avkap007 wants to merge 8 commits intoryanstephen:mainfrom
Open
Pr/pop out chat - to allow for long running tasks to have their dedicated window#49avkap007 wants to merge 8 commits intoryanstephen:mainfrom
avkap007 wants to merge 8 commits intoryanstephen:mainfrom
Conversation
add a title bar control on the dock popover to open the same terminal in a floating window. the popped-out window keeps its own provider choice in memory, routes copy/refresh/provider menu to the right session, tears down on close, and survives style switches. also terminate detached sessions on quit, refresh detached chrome when the global theme changes, and re-apply terminal colors after rebuilds. character content view is non-opaque so alpha video hit testing stays consistent.
tear down after NSWindowDidClose instead of willClose, and defer session terminate to the next main run loop so closing a second pop-out does not deadlock appkit.
Author
|
demo video pop-out-chat-demo-short.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a pop-out button to the dock chat popover that detaches the conversation into its own resizable window. the detached window keeps its own session and provider (can be switched independently), and the character resumes walking after pop-out. the goal is to allow for long running tasks to have their dedicated window
what's included: