Closed
Conversation
=== Breaking changes - Use netlink-packet-route 0.30. (7bfbbf5) - Deprecated `NeighbourAddRequest::link_layer_address()`, please use `NeighbourAddRequest::link_local_address()`. (7bfbbf5) === New features - N/A === Bug fixes - addr: only assign broadcast when subnet over /31. (7c16a2d) Signed-off-by: Gris Ge <cnfourt@gmail.com>
Member
Author
|
Let me review more pending patches. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version of the rtnetlink crate to 0.21.0 and updates the CHANGELOG to include breaking changes and bug fixes. A review comment identifies that the deprecation notice for NeighbourAddRequest methods in the CHANGELOG is reversed and should be corrected to accurately reflect the implementation.
Comment on lines
+5
to
+6
| - Deprecated `NeighbourAddRequest::link_layer_address()`, please use | ||
| `NeighbourAddRequest::link_local_address()`. (7bfbbf5) |
There was a problem hiding this comment.
The changelog entry for the deprecation is reversed. According to the implementation in src/neighbour/add.rs, link_local_address is the method being deprecated in favor of link_layer_address (which corresponds to the NDA_LLADDR attribute).
- Deprecated `NeighbourAddRequest::link_local_address()`, please use
`NeighbourAddRequest::link_layer_address()`. (7bfbbf5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
=== Breaking changes
NeighbourAddRequest::link_layer_address(), please useNeighbourAddRequest::link_local_address(). (7bfbbf5)=== New features
=== Bug fixes