Skip to content

Fix a bunch of small issues with our GitHub comments viewer #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 7 commits into from
Apr 19, 2026
+40 −19
Merged

Fix a bunch of small issues with our GitHub comments viewer #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f948780
Keep the badges round no matter the outer constraint
Urgau Apr 17, 2026
3de5771
Wrap the issue/PR title if too long
Urgau Apr 17, 2026
5af26dd
Only make the cursor a pointer for review thread headers
Urgau Apr 17, 2026
ef20cec
Add highlighting around the targeted (by url) comment or review-thread
Urgau Apr 17, 2026
1131178
Add self-link to the author-ship time of each comment/review comment
Urgau Apr 17, 2026
f5a83e7
Add missing background color in suggested code
Urgau Apr 17, 2026
268042b
Make the reaction buttons so the emoji and number act as one entity
Urgau Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/gh_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ use crate::{
utils::{immutable_headers, is_known_and_public_repo},
};

pub const STYLE_URL: &str = "/gh-comments/style@0.0.7.css";
pub const STYLE_URL: &str = "/gh-comments/style@0.0.8.css";
pub const MARKDOWN_URL: &str = "/gh-comments/github-markdown@20260117.css";
pub const SELF_CONTAINED_URL: &str = "/gh-comments/self_contained@0.0.2.js";

Expand Down Expand Up @@ -270,7 +270,7 @@ pub async fn gh_comments(
write!(
html,
r###"<main class="comments-container">
<h1 class="title"><bdi class="markdown-body">{title_html}</bdi> <a class="github-link" href="https://github.com/{owner}/{repo}/issues/{issue_id}">{owner}/{repo}#{issue_id}</a></h1>
<h1 class="title"><span class="markdown-body">{title_html}</span> <a class="github-link" href="https://github.com/{owner}/{repo}/issues/{issue_id}">{owner}/{repo}#{issue_id}</a></h1>
"###,
)?;

Expand Down Expand Up @@ -551,8 +551,8 @@ fn write_comment_as_html(
<img src="{author_avatar_url}" alt="{author_login} Avatar" class="avatar">
</a>
<div class="author-info">
<a href="https://github.com/{author_login}" target="_blank">{author_login}</a>
<span>on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></span><span> · hidden as {minimized_reason}</span>
<a href="https://github.com/{author_login}" target="_blank" class="author-info-name">{author_login}</a>
<a href="#{id}">on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></a><span> · hidden as {minimized_reason}</span>
</div>
</div>

Expand Down Expand Up @@ -584,17 +584,17 @@ fn write_comment_as_html(
<div id="{id}" class="comment">
<div class="comment-header">
<div class="author-info desktop">
<a href="https://github.com/{author_login}" target="_blank">{author_login}</a>
<span>on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></span>{edited}
<a href="https://github.com/{author_login}" target="_blank" class="author-info-name">{author_login}</a>
<a href="#{id}">on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></a>{edited}
</div>

<div class="author-mobile">
<a href="https://github.com/{author_login}" target="_blank">
<img src="{author_avatar_url}" alt="{author_login} Avatar" class="avatar">
</a>
<div class="author-info">
<a href="https://github.com/{author_login}" target="_blank">{author_login}</a>
<span>on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></span>{edited}
<a href="https://github.com/{author_login}" target="_blank" class="author-info-name">{author_login}</a>
<a href="#{id}">on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></a>{edited}
</div>
</div>

Expand Down Expand Up @@ -672,8 +672,8 @@ fn write_review_as_html(
<div class="review-header">
<div class="review-badge {badge_color}">{badge_svg}</div>
<div class="author-info">
<a href="https://github.com/{author_login}" target="_blank">{author_login}</a>
<span>{state_message} on <span data-utc-time="{submitted_at_rfc3339}">{submitted_at}</span></span>
<a href="https://github.com/{author_login}" target="_blank" class="author-info-name">{author_login}</a>
<a href="#{id}">{state_message} on <span data-utc-time="{submitted_at_rfc3339}">{submitted_at}</span></a>
</div>
</div>
</div>
Expand Down Expand Up @@ -803,8 +803,8 @@ fn write_review_thread_as_html(
<a href="https://github.com/{author_login}" target="_blank">
<img src="{author_avatar_url}" alt="{author_login} Avatar" class="avatar avatar-small">
</a>
<a href="https://github.com/{author_login}" target="_blank">{author_login}</a>
<span>on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></span>{edited}
<a href="https://github.com/{author_login}" target="_blank" class="author-info-name">{author_login}</a>
<a href="#{id}">on <span data-utc-time="{created_at_rfc3339}">{created_at}</span></a>{edited}
</div>
<a href="{comment_url}" target="_blank" class="github-link">View on GitHub</a>
</div>
Expand Down Expand Up @@ -894,7 +894,7 @@ fn write_reaction_groups_as_html(

write!(
buffer,
r##"<div class="reaction">{emoji}<span class="reaction-number">{total_count}</span></div>"##
r##"<button class="reaction" disabled="disabled">{emoji}<span class="reaction-number">{total_count}</span></button>"##
)?;
}

Expand Down
33 changes: 27 additions & 6 deletions src/gh_comments/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
--fg-accent: #0969da;
--border-default: #d0d7de;
--toc-width: min(330px, 75vw);
--bgColor-success-muted: #46954a26;
--bgColor-danger-muted: #e5534b1a;
}

@media (prefers-color-scheme: dark) {
Expand Down Expand Up @@ -65,7 +67,7 @@ body {
margin-bottom: 0;
}

.title bdi {
.title .markdown-body {
font-size: 28px;
font-weight: 600;
display: inline-block;
Expand All @@ -91,6 +93,10 @@ body {
overflow: hidden;
}

.comment:target, .review-thread:target {
box-shadow: 0 0 0 1px var(--fg-accent);
}

.review-thread {
margin-left: 80px;
margin-bottom: 1rem;
Expand All @@ -105,6 +111,9 @@ body {
padding: 8px 12px;
font-size: 0.9em;
color: var(--fg-muted);
}

.review-thread-header {
cursor: pointer;
}

Expand All @@ -117,13 +126,17 @@ details:not([open]) > .review-thread-header {
padding: 16px;
}

.review-thread-comment {
position: relative;
padding: 0.5rem 1rem;
}

.review-thread-comment:first-child {
padding-top: 1rem;
}

.review-thread-comment {
position: relative;
padding: 0.5rem 1rem;
.review-thread-comment:target {
box-shadow: inset 0 0 0 1px var(--fg-accent);
}

.review-header, .review-thread-comment-header {
Expand Down Expand Up @@ -199,15 +212,19 @@ details:not([open]) > .review-thread-header {
}

.author-info a {
color: var(--fg-default);
font-weight: 600;
color: var(--fg-muted);
text-decoration: none;
}

.author-info a:hover {
text-decoration: underline;
}

.author-info .author-info-name {
color: var(--fg-default);
font-weight: 600;
}

.github-link {
font-size: 0.85em;
color: var(--fg-muted);
Expand All @@ -223,6 +240,7 @@ details:not([open]) > .review-thread-header {
display: flex;
align-items: center;
justify-content: center;
flex-shrink: 0;
width: 2rem;
height: 2rem;
border-radius: 50%;
Expand Down Expand Up @@ -278,12 +296,14 @@ details:not([open]) > .review-thread-header {
.reaction {
border-radius: 100px;
border: 0.00625rem solid var(--border-default);
background-color: transparent;
padding: 5px 9px;
font-size: 13px;
}

.reaction .reaction-number {
margin-left: 0.35rem;
color: var(--fg-muted);
}

/* === Tab links === */
Expand All @@ -299,6 +319,7 @@ details:not([open]) > .review-thread-header {
/* === Markdown overrides === */
.markdown-body {
font-size: 14px;
overflow-wrap: anywhere;
}

.markdown-body .user-mention {
Expand Down