Rename ShortcutCommand to ReviewCommand#2166
Draft
apiraino wants to merge 1 commit intorust-lang:masterfrom
Draft
Rename ShortcutCommand to ReviewCommand#2166apiraino wants to merge 1 commit intorust-lang:masterfrom
apiraino wants to merge 1 commit intorust-lang:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
The ShortcutCommand was born to handle one case (reviews) but I'd like to expand its scope to handle more convenience custom shortcuts for commands that will modify labels. However just adding more code would make things a bit confusing, so I'd first start clarifying the scope of the existing code and in subsequent patches add more shortcut commands. At a high level, I can imagine something like this: - shortcut::ReviewCommand to handle commands like `author`, `review`, `ready`, etc. - shortcut::RegressionCommand to handle future commands for quick switching label regressions (todo) - shortcut:NewCommand (and so on) Functionally this patch changes nothing, it's just renaming things.
apiraino
force-pushed
the
rename-shortcut-command
branch
from
768b4a8 to
e304185
Compare
Collaborator
|
☔ The latest upstream changes (possibly #2344) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ShortcutCommand was born to handle one case (reviews) but I'd like to expand its scope to handle more convenience custom shortcuts for commands that will modify labels.
However just adding more code would make things a bit confusing, so I'd first start clarifying the scope of the existing code and in subsequent patches add more shortcut commands.
At a high level, I can imagine something like this:
author,review,ready, etc.Functionally this patch changes nothing, it's just renaming things.
I wrote about this on Zulip.
Thanks for having a look here. I'd like to get some opinons if this makes sense before moving forward with further work.
r?